Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multi-select, simplify profile selection code #223

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

davenice
Copy link
Contributor

@davenice davenice commented Feb 4, 2025

Resolves #222

What It Does
Removes multi-select
Simplifies profile selection code so edit and delete profile match
Behaviour now in line with Zowe Explorer

Review Checklist
I certify that I have:

@davenice davenice requested a review from chinmdas February 4, 2025 15:23
@davenice davenice self-assigned this Feb 4, 2025
@davenice davenice marked this pull request as ready for review February 4, 2025 15:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 28.66%. Comparing base (1087db6) to head (f266988).

Files with missing lines Patch % Lines
packages/vsce/src/trees/CICSTree.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   28.56%   28.66%   +0.09%     
==========================================
  Files         147      147              
  Lines        5031     5003      -28     
  Branches      882      873       -9     
==========================================
- Hits         1437     1434       -3     
+ Misses       3594     3569      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JTonda JTonda requested a review from zFernand0 February 4, 2025 16:03
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Thanks for disabling the right-click > manage profile on multi-select of the profiles 🙏
It cause a very strange error message 😅


Oh, Dave...
You should also be able to work out of a branch instead of a fork (in case that's easier) 😋

Copy link
Contributor

@chinmdas chinmdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great..!!!

Copy link
Contributor

@AndrewTwydell AndrewTwydell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks 👍🏼

@AndrewTwydell AndrewTwydell merged commit df6656b into zowe:main Feb 5, 2025
18 checks passed
@AndrewTwydell AndrewTwydell added the release-patch Indicates a patch to existing code has been applied label Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

Release succeeded for the main branch. 🎉

The following packages have been published:

Powered by Octorelease 🚀

@davenice davenice deleted the niced-fix-open-profile branch February 6, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Editing profile results in exception
5 participants