-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove multi-select, simplify profile selection code #223
Conversation
Signed-off-by: Dave Nice <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
==========================================
+ Coverage 28.56% 28.66% +0.09%
==========================================
Files 147 147
Lines 5031 5003 -28
Branches 882 873 -9
==========================================
- Hits 1437 1434 -3
+ Misses 3594 3569 -25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 😋
Thanks for disabling the right-click > manage profile on multi-select of the profiles 🙏
It cause a very strange error message 😅
Oh, Dave...
You should also be able to work out of a branch instead of a fork (in case that's easier) 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great..!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks 👍🏼
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Resolves #222
What It Does
Removes multi-select
Simplifies profile selection code so edit and delete profile match
Behaviour now in line with Zowe Explorer
Review Checklist
I certify that I have: